RE: [PATCH v2 2/2] scsi: ufs: Add HCI capabilities sysfs group

[Avri Altman]

> 
> On 8/4/24 12:21 AM, Avri Altman wrote:
> > +What:
> /sys/bus/platform/drivers/ufshcd/ufshci_capabilities/capabilities
> 
> That path seems wrong to me. I think that "ufshcd" should be changed into
> something like ${host_driver_name}/${ufshci_instance_name}. An example from
> a Pixel 8 device:
> 
> $ adb shell ls /sys/bus/platform/drivers/*ufs*
> /sys/bus/platform/drivers/exynos-ufs:
> 13200000.ufs
> module
> uevent
> 
> /sys/bus/platform/drivers/ufshcd-hisi:
> bind
> uevent
> unbind
Yeah - nor on my rb5.  Here it is in: /sys/devices/platform/soc@0/1d84000.ufshc/ufshci_capabilities
So I am wondering if having something like the below is acceptable?
/sys/devices/platform/<platform-specific-path>/ufshci_capabilities

Thanks,
Avri 

> 
> > +What:
> /sys/bus/platform/devices/*.ufs/ufshci_capabilities/capabilities
> > +Date:                August 2024
> > +Contact:     Avri Altman <avri.altman@xxxxxxx>
> > +Description:
> > +             Host Capabilities register group: host controller capabiities register.
> > +             Symbol - CAP.  Offset: 0x00 - 0x03.
> 
> Please fix the spelling error that was already reported by Keoseong Park.
> Otherwise this patch looks good to me.
> 
> Thanks,
> 
> Bart.