Re: [PATCH] Documentation: dontdiff: remove 'utf8data.h'

From: Jonathan Corbet
Date: Thu Aug 08 2024 - 09:17:46 EST


Guo Xuenan <guoxuenan@xxxxxxxxxx> writes:

> From: ganjie <ganjie5@xxxxxxxxxx>
>
> Commit 2b3d04787012 ("unicode: Add utf8-data module") changed the
> database file from 'utf8data.h' to 'utf8data.c' to build separate
> module, but it seems forgot to update Documentation/dontdiff. Remove
> 'utf8data.h' and add 'utf8data.c'.
>
> Signed-off-by: ganjie <ganjie5@xxxxxxxxxx>
> ---
> Documentation/dontdiff | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dontdiff b/Documentation/dontdiff
> index 3c399f132e2d..94b3492dc301 100644
> --- a/Documentation/dontdiff
> +++ b/Documentation/dontdiff
> @@ -262,7 +262,7 @@ vsyscall_32.lds
> wanxlfw.inc
> uImage
> unifdef
> -utf8data.h
> +utf8data.c
> wakeup.bin
> wakeup.elf
> wakeup.lds

I'll apply this, but does anybody actually use the dontdiff file
anymore? I think it's old and, if being used, actively harmful; for
example, it masks changes to "parse.c", an instance of which was added
to git in January.

Is there a reason to not just remove this file?

Thanks,

jon