Re: [PATCH net-next v2 2/3] phy: Add Open Alliance helpers for the PHY framework

From: Russell King (Oracle)
Date: Thu Aug 08 2024 - 09:33:31 EST


On Thu, Aug 08, 2024 at 03:08:32PM +0200, Oleksij Rempel wrote:
> Introduce helper functions specific to Open Alliance diagnostics,
> integrating them into the PHY framework. Currently, these helpers
> are limited to 1000BaseT1 specific TDR functionality.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
> drivers/net/phy/Makefile | 2 +-
> drivers/net/phy/open_alliance_helpers.c | 70 +++++++++++++++++++++++++
> include/linux/open_alliance_helpers.h | 47 +++++++++++++++++
> 3 files changed, 118 insertions(+), 1 deletion(-)
> create mode 100644 drivers/net/phy/open_alliance_helpers.c
> create mode 100644 include/linux/open_alliance_helpers.h
>
> diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
> index 202ed7f450da6..8a46a04af01a5 100644
> --- a/drivers/net/phy/Makefile
> +++ b/drivers/net/phy/Makefile
> @@ -2,7 +2,7 @@
> # Makefile for Linux PHY drivers
>
> libphy-y := phy.o phy-c45.o phy-core.o phy_device.o \
> - linkmode.o
> + linkmode.o open_alliance_helpers.o

Given that most PHY drivers aren't open alliance, would it be better
to have a config symbol that can be selected by PHY drivers that need
it?

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!