Re: [PATCH 1/2] serial: 8250_platform: remove ACPI_PTR() annotation

From: Andy Shevchenko
Date: Thu Aug 08 2024 - 10:16:43 EST


On Wed, Aug 07, 2024 at 09:57:43AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The acpi_platform_serial_table[] array is defined globally without
> an #ifdef check for CONFIG_ACPI, so ACPI_PTR() makes no sense
> here:
>
> drivers/tty/serial/8250/8250_platform.c:271:36: error: 'acpi_platform_serial_table' defined but not used [-Werror=unused-const-variable=]
> 271 | static const struct acpi_device_id acpi_platform_serial_table[] = {

Yeah, that patch went into kernel without my review as I was on a long leave.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko