Re: [PATCH] arm/virt: place power button pin number on a define

[Peter Maydell]

On Thu, 8 Aug 2024 at 13:55, Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
>
> Having magic numbers inside the code is not a good idea, as it
> is error-prone. So, instead, create a macro with the number
> definition.
>
> Link: https://lore.kernel.org/qemu-devel/CAFEAcA-PYnZ-32MRX+PgvzhnoAV80zBKMYg61j2f=oHaGfwSsg@xxxxxxxxxxxxxx/
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> Suggested-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Reviewed-by: Igor Mammedov <imammedo@xxxxxxxxxx>



Applied to target-arm.next, thanks.

-- PMM