Re: [PATCH 1/1] arm64: dts: lx2160a: Change PCIe compatible string to fsl,ls2088a-pcie

From: Conor Dooley
Date: Thu Aug 08 2024 - 11:34:57 EST


On Thu, Aug 08, 2024 at 11:31:20AM -0400, Frank Li wrote:
> The mass production lx2160 rev2 use designware PCIe Controller. Old Rev1
> which use mobivel PCIe controller was not supported. Although uboot
> fixup can change compatible string fsl,lx2160a-pcie to fsl,ls2088a-pcie
> since 2019, it is quite confused and should correctly reflect hardware
> status in fsl-lx2160a.dtsi.

This does not begin to explain why removing the soc-specific compatible,
and instead putting the compatible for another soc is the right fix.
Come up with a new compatible for this device, that perhaps falls back
to the ls2088a, but this change doesn't seem right to me.


Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature