Re: [net-next PATCH v10 01/11] octeontx2-pf: Refactoring RVU driver

[Jiri Pirko]

Mon, Aug 05, 2024 at 03:18:05PM CEST, gakula@xxxxxxxxxxx wrote:
>Refactoring and export list of shared functions such that
>they can be used by both RVU NIC and representor driver.
>
>Signed-off-by: Geetha sowjanya <gakula@xxxxxxxxxxx>
>Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
>---
> .../ethernet/marvell/octeontx2/af/common.h    |   2 +
> .../net/ethernet/marvell/octeontx2/af/mbox.h  |   2 +
> .../net/ethernet/marvell/octeontx2/af/npc.h   |   1 +
> .../net/ethernet/marvell/octeontx2/af/rvu.c   |  11 +
> .../net/ethernet/marvell/octeontx2/af/rvu.h   |   1 +
> .../marvell/octeontx2/af/rvu_debugfs.c        |  27 --
> .../ethernet/marvell/octeontx2/af/rvu_nix.c   |  47 ++--
> .../marvell/octeontx2/af/rvu_npc_fs.c         |   5 +
> .../ethernet/marvell/octeontx2/af/rvu_reg.h   |   4 +
> .../marvell/octeontx2/af/rvu_struct.h         |  26 ++
> .../marvell/octeontx2/af/rvu_switch.c         |   2 +-
> .../marvell/octeontx2/nic/otx2_common.c       |   6 +-
> .../marvell/octeontx2/nic/otx2_common.h       |  43 ++--
> .../ethernet/marvell/octeontx2/nic/otx2_pf.c  | 240 +++++++++++-------
> .../marvell/octeontx2/nic/otx2_txrx.c         |  17 +-
> .../marvell/octeontx2/nic/otx2_txrx.h         |   3 +-
> .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |   7 +-
> 17 files changed, 266 insertions(+), 178 deletions(-)

How can anyone review this?

If you need to refactor the code in preparation for a feature, you can
do in in a separate patchset sent before the feature appears. This patch
should be split into X patches. One logical change per patch.