Re: [PATCH 2/8] ASoC: SOF: amd: fix for acp error reason registers wrong offset

[Mark Brown]

On Wed, Aug 07, 2024 at 10:43:14AM +0530, Vijendar Mukunda wrote:
> Fix the incorrect register offsets for acp error reason registers.
> Add 'acp_sw0_i2s_err_reason' as register field in acp descriptor structure
> and update the value based on the acp variant.
> ACP_SW1_ERROR_REASON register was added from Rembrandt platform onwards.
> Add conditional check for the same.
> 
> Fixes: 96eb81851012 ("ASoC: SOF: amd: add interrupt handling for SoundWire manager devices")

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_irq_handler’:
/build/stage/linux/sound/soc/sof/amd/acp.c:407:26: error: ‘struct acp_dev_data’ h
as no member named ‘pci_rev’
  407 |                 if (adata->pci_rev >= ACP_RMB_PCI_ID)
      |                          ^~
/build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_power_on’:
/build/stage/linux/sound/soc/sof/amd/acp.c:444:22: error: ‘struct acp_dev_data’ h
as no member named ‘pci_rev’
  444 |         switch (adata->pci_rev) {
      |                      ^~

Attachment: signature.asc
Description: PGP signature