Re: [PATCH v24 23/34] ALSA: usb-audio: Prevent starting of audio stream if in use

[Wesley Cheng]

On 8/8/2024 7:54 AM, Amadeusz Sławiński wrote:
> On 8/8/2024 2:36 PM, Pierre-Louis Bossart wrote:
>>
>>
>> On 8/8/24 14:11, Amadeusz Sławiński wrote:
>>> On 8/8/2024 3:19 AM, Wesley Cheng wrote:
>>>> Hi Amadeusz,
>>>>
>>>> On 8/6/2024 7:51 AM, Amadeusz Sławiński wrote:
>>>>> On 8/1/2024 3:17 AM, Wesley Cheng wrote:
>>>>>> With USB audio offloading, an audio session is started from the ASoC
>>>>>> platform sound card and PCM devices.  Likewise, the USB SND path is
>>>>>> still
>>>>>> readily available for use, in case the non-offload path is desired.  In
>>>>>> order to prevent the two entities from attempting to use the USB bus,
>>>>>> introduce a flag that determines when either paths are in use.
>>>>>>
>>>>>
>>>>> How can this happen? Can you provide some example with list of
>>>>> devices and which one should block the other? If I recall correctly
>>>>> devices are already exclusive unless you support substreams which
>>>>> ASoC does not at the moment.
>>>>>
>>>>   From past discussions, I think so far everyone is on board with the
>>>> idea of having both the USB sound card and PCM devices exist in
>>>> conjunction w/ the USB offload path, which is going to be done over
>>>> the ASoC platform card.  So for example,
>>>>
>>>
>>> Sorry, I must have missed that and examples in documentation could
>>> probably be a bit better, it is bit late at patchset 24 that I
>>> understood about this now. And is part of a reason why I was confused
>>> about kcontrol implementation.
>>>
>>>> / # cat /proc/asound/cards
>>>>    0 [SM8250MTPWCD938]: sm8250 - SM8250-MTP-WCD9380-WSA8810-VA-D
>>>>                         SM8250-MTP-WCD9380-WSA8810-VA-DMIC
>>>>    1 [C320M          ]: USB-Audio - Plantronics C320-M
>>>>                         Plantronics Plantronics C320-M at usb-xhci-
>>>> hcd.1.auto-1.2, full speed
>>>>
>>>> This device currently has the following sound cards within the system:
>>>>
>>>> - card#0 - ASoC platform card: handles USB offload, speaker, etc...
>>>>
>>>> - card#1 - USB SND card: card created for interacting with the
>>>> connected USB device.
>>>>
>>>> So now, with USB offloading in the picture, there are basically two
>>>> paths that can start attempting to utilize the same USB device
>>>> endpoints.  Let's keep it simple and assume the device only has one
>>>> playback substream (which means only one PCM device)
>>>>
>>>> /proc/asound/card1 # cat stream0
>>>> Plantronics Plantronics C320-M at usb-xhci-hcd.1.auto-1.2, full
>>>> speed : USB Audio
>>>>
>>>> Playback:
>>>>     Status: Stop
>>>>     Interface 2
>>>>       Altset 1
>>>>       Format: S16_LE
>>>>       Channels: 2
>>>>       Endpoint: 0x01 (1 OUT) (ADAPTIVE)
>>>>       Rates: 8000, 16000, 24000, 32000, 44100, 48000
>>>>       Bits: 16
>>>>       Channel map: FL FR
>>>>
>>>> So the patch here will prevent transfers from happening from both the
>>>> offload path and directly over the USB SND PCM device, which
>>>> correlates to the following paths:
>>>>
>>>> - offload: card#0 pcm#0
>>>>
>>>> - USB SND: card#1 pcm#0
>>>
>>> Well, it's one way to do that.
>>>
>>> Personally I would just reuse USB FEs and when opening one check if it
>>> can be offloaded:
>>> * check if someone disabled Offload on FE
>>> * check if it is connected to HW that can do Offload at all
>>> * check if Offload streams are available on backing HW
>>> * check if audio formats are supported by above HW
>>> * do any other checks that may be needed
>>> and then just redirect FE setup to relevant driver doing offload if
>>> able, otherwise just go standard path.
>>
>> How would userspace know which 'USB FE' to use?
>>
>
> That's my point, the same one as it would use doing normal playback/capture on systems which don't have Offload.
>
> If I attach USB Headphones, as a user my expectation would be to use playback FE on USB card it exposes, not to spend time setting some controls and telling it to use some FE from other card.
>
IMO I think the user should have the ability to choose whether or not to enable the offload path, since there are a lot of different USB audio devices in the market.  Obviously, the audio DSP will try its best to support every device we check for, but there might be a few outliers that may behave differently.  In addition, the code complexity that would be involved in bridging the PCM device exposed by USB SND into ASoC will be much more invasive to SND core code.  At least as of now, if the offload code is added, and userspace doesn't know anything about it, then the default USB SND path is taken and that won't break any current userspace applications.

Now, if we go and add some kernel based offload routing, and forcing that onto every userspace application, and we break that use case, that would be a problem.  In the end, I think if userspace wants to enable offloading they should need to have some changes implemented to account for it.  In discussions with Pierre, maybe enabling the offload path can be on a policy based condition, such as a "low power/power aware" audio path, and not something that is always enabled.

Thanks

Wesley Cheng

> With current design there are _two_ separate FEs, on _two_ separate cards, which are linked by kcontrol and which block each other. I'm rather confused how basic userspace application knows which one to use in this case. (By now of course I know that it needs to read kcontrol to see if and where it is offloaded and then open the FE on the card, but in my opinion it is unnecessarily convoluted.)
>
>> The discovery and mapping between cards and devices is the main problem.
>>
>
> And "offloading" decision to the user/sound server/HAL doesn't help in my opinion.
>
>> It's much simpler to start from a generic "USB-Audio" card, and check if
>> the functionality exposed by one PCM device is offloaded to another
>> ASoC-based card. Then all the interaction can start with this offloaded
>> device without any guesswork on the mapping between cards/devices.
>>
>
> That's the point, currently there needs to be some guesswork involved, because you need to check kcontrols to see if the endpoint can be offloaded and open the other FE it points at, instead of directly opening the one you usually would, and having it Offloaded by kernel. It is adding more work on userspace side, which will require special handling to work correctly.
>
>> The point is that the USB-Audio card will always be there, whereas those
>> ASoC cards will have different names and implementation restrictions. In
>> the example we have here, if you want to capture audio you *have* to use
>> the USB-Audio card.
>>
>
> Yes and with the description above it would be just one of the checks after which it would decide that it can't do Offload on capture path and open it in standard way, I see no problem?
>
>> In other words, it's just an endianness type of debate with no clear
>> difference between solutions and a matter of personal preference. The
>> reality is that there's a clear asymmetrical pattern. The USB-Audio card
>> is always present and usable, the ASoC offloaded cards are only present
>> in specific implementations and only usable if conditions are met.
>
> In my opinion even if it is specific use case, there is no reason to make it more complicated than it needs to be. From my point of view problem with current design is that instead of being mostly transparent to userspace (when it could be), it adds more work for it.
>