Re: [PATCH v2 2/3] irqdomain: Allow giving name suffix for domain

[Thomas Gleixner]

On Thu, Aug 08 2024 at 15:35, Matti Vaittinen wrote:
>  
> +		if (info->name_suffix)
> +			name = bus_token ?
> +				kasprintf(GFP_KERNEL, "%pfw-%s-%d", fwnode,
> +					  info->name_suffix, bus_token) :
> +				kasprintf(GFP_KERNEL, "%pfw-%s", fwnode, info->name_suffix);
> +		else
> +			name = bus_token ?
> +				kasprintf(GFP_KERNEL, "%pfw-%d", fwnode, bus_token) :
> +				kasprintf(GFP_KERNEL, "%pfw", fwnode);

This really makes my eyes bleed. I know you copied the existing mess,
but that does not make it less tasteless.

I'll send out a cleanup for this horrorshow in a few.

Thanks,

        tglx