Re: [PATCH 6.10 000/809] 6.10.3-rc3 review

[John David Anglin]

On 2024-08-08 7:33 p.m., Linus Torvalds wrote:
> On Thu, 8 Aug 2024 at 15:30, John David Anglin <dave.anglin@xxxxxxxx> wrote:
> > > I believe the shladd instruction should be changed to shladd,l (shift left and add logical).
> > diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S
> > index ab23e61a6f01..1ec60406f841 100644
> > --- a/arch/parisc/kernel/entry.S
> > +++ b/arch/parisc/kernel/entry.S
> > @@ -399,7 +399,7 @@
> > -    shladd        \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */
> > +    shladd,l    \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */
> This doesn't seem wrong, but doesn't RFIR already restore the status word?
Yes.
> So even if the itlb fill modifies C/B, I don't see why that should
> actually matter.
Probably won't help unless there's a bug in qemu rfir emulation.

Dave

--
John David Anglin  dave.anglin@xxxxxxxx