Re: [PATCH v3] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()
From: Viresh Kumar
Date: Fri Aug 09 2024 - 03:21:28 EST
On 09-08-24, 06:08, Dhananjay Ugwekar wrote:
> Fix the reference counting of cpufreq_policy object in amd_pstate_update()
> function by adding the missing cpufreq_cpu_put().
>
> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value")
> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@xxxxxxx>
> Reviewed-by: Perry Yuan <perry.yuan@xxxxxxx>
> ---
> drivers/cpufreq/amd-pstate.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 68c616b572f2..eff039ba49ee 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -554,12 +554,15 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
> }
>
> if (value == prev)
> - return;
> + goto cpufreq_policy_put;
>
> WRITE_ONCE(cpudata->cppc_req_cached, value);
>
> amd_pstate_update_perf(cpudata, min_perf, des_perf,
> max_perf, fast_switch);
> +
> +cpufreq_policy_put:
> + cpufreq_cpu_put(policy);
> }
>
> static int amd_pstate_verify(struct cpufreq_policy_data *policy)
Applied. Thanks.
--
viresh