Re: [PATCH] lib/rhashtable: cleanup fallback check in bucket_table_alloc()
From: Michal Hocko
Date: Fri Aug 09 2024 - 03:57:10 EST
On Tue 06-08-24 08:39:27, Davidlohr Bueso wrote:
> Upon allocation failure, the current check with the nofail bits
> is unnecessary, and further stands in the way of discouraging
> direct use of __GFP_NOFAIL. Remove this and replace with the
> proper way of determining if doing a non-blocking allocation
> for the nested table case.
>
> Suggested-by: Michal Hocko <mhocko@xxxxxxxx>
> Signed-off-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Thanks. This is not really something I feel qualified to ack but the
change looks good to me.
> ---
> lib/rhashtable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> index dbbed19f8fff..6c902639728b 100644
> --- a/lib/rhashtable.c
> +++ b/lib/rhashtable.c
> @@ -189,7 +189,7 @@ static struct bucket_table *bucket_table_alloc(struct rhashtable *ht,
>
> size = nbuckets;
>
> - if (tbl == NULL && (gfp & ~__GFP_NOFAIL) != GFP_KERNEL) {
> + if (tbl == NULL && !gfpflags_allow_blocking(gfp)) {
> tbl = nested_bucket_table_alloc(ht, nbuckets, gfp);
> nbuckets = 0;
> }
> --
> 2.45.2
--
Michal Hocko
SUSE Labs