RE: [PATCH v4 5/7] iommu/vt-d: Factor out helpers from domain_context_mapping_one()

[Tian, Kevin]

> From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Sent: Friday, August 9, 2024 1:54 PM
> 
> Extract common code from domain_context_mapping_one() into new
> helpers,
> making it reusable by other functions such as the upcoming identity domain
> implementation. No intentional functional changes.
> 
> Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

with a nit on naming:

> +static void copied_context_tear_down(struct intel_iommu *iommu,
> +				     struct context_entry *context,
> +				     u8 bus, u8 devfn)

tear_down_copied_conext


> +static void context_present_cache_flush(struct intel_iommu *iommu, u16
> did,
> +					u8 bus, u8 devfn)

flush_present_context_cache