Re: [PATCH] pinctrl: qcom: x1e80100: Fix special pin offsets

From: Abel Vesa
Date: Fri Aug 09 2024 - 04:59:12 EST


On 24-08-09 02:22:04, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx>
>
> Remove the erroneus 0x100000 offset to prevent the boards from crashing
> on pin state setting, as well as for the intended state changes to take
> effect.
>
> Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver")
> Signed-off-by: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx>

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>

> ---
> drivers/pinctrl/qcom/pinctrl-x1e80100.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-x1e80100.c b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> index 6cd4d10e6fd6..65ed933f05ce 100644
> --- a/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> +++ b/drivers/pinctrl/qcom/pinctrl-x1e80100.c
> @@ -1805,10 +1805,10 @@ static const struct msm_pingroup x1e80100_groups[] = {
> [235] = PINGROUP(235, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [236] = PINGROUP(236, aon_cci, qdss_gpio, _, _, _, _, _, _, _),
> [237] = PINGROUP(237, _, _, _, _, _, _, _, _, _),
> - [238] = UFS_RESET(ufs_reset, 0x1f9000),
> - [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1f2000, 14, 6),
> - [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1f2000, 11, 3),
> - [241] = SDC_QDSD_PINGROUP(sdc2_data, 0x1f2000, 9, 0),
> + [238] = UFS_RESET(ufs_reset, 0xf9000),
> + [239] = SDC_QDSD_PINGROUP(sdc2_clk, 0xf2000, 14, 6),
> + [240] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xf2000, 11, 3),
> + [241] = SDC_QDSD_PINGROUP(sdc2_data, 0xf2000, 9, 0),
> };
>
> static const struct msm_gpio_wakeirq_map x1e80100_pdc_map[] = {
>
> ---
> base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
> change-id: 20240809-topic-h_sdc-eb6edad718cd
>
> Best regards,
> --
> Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx>
>