RE: [PATCH] mwifiex: duplicate static structs used in driver instances

From: Ping-Ke Shih
Date: Fri Aug 09 2024 - 05:27:53 EST


Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> On Fri, Aug 09, 2024 at 08:49:32AM +0000, Ping-Ke Shih wrote:
> > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> > > + wiphy->bands[NL80211_BAND_2GHZ] = devm_kmemdup(adapter->dev,
> > > + &mwifiex_band_2ghz,
> > > + sizeof(mwifiex_band_2ghz),
> > > + GFP_KERNEL);
> >
> > It seems like you forget to free the duplicate memory somewhere?
>
> It's freed automatically when adapter->dev is released, see the various
> devm_* functions
>

Cool. Thanks for the info.