Re: [PATCH] rust: sort includes in bindings_helper.h
From: Miguel Ojeda
Date: Fri Aug 09 2024 - 08:59:30 EST
On Fri, Aug 9, 2024 at 8:42 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> Dash has ascii value 45 and underscore has ascii value 95, so to
> correctly sort the includes, the underscore should be last.
>
> Fixes: 3253aba3408a ("rust: block: introduce `kernel::block::mq` module")
Looks good to me (`LC_ALL=C`), thanks!
I can take it; otherwise:
Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
I am not sure if this should count as a bug/fix (there is an
recent/ongoing debate about the Fixes tag).
(This kind of issues can be also opened as "good first issues", by the
way, i.e. as a way to get contributors to set their email workflow.)
Cheers,
Miguel