Re: [PATCH] rust: sort includes in bindings_helper.h

From: Alice Ryhl
Date: Fri Aug 09 2024 - 09:19:47 EST


On Fri, Aug 9, 2024 at 3:01 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> On 8/9/24 8:42 AM, Alice Ryhl wrote:
> > Dash has ascii value 45 and underscore has ascii value 95, so to
> > correctly sort the includes, the underscore should be last.
> >
> > Fixes: 3253aba3408a ("rust: block: introduce `kernel::block::mq` module")
>
> I don't think this patch needs a "Fixes" tag, it's usually for bugs only.
>
> But it still makes sense to mention the commit that introduced the include
> in the commit message.

Ok. I can make this change.

Alice