Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113
From: Nuno Sá
Date: Fri Aug 09 2024 - 10:12:27 EST
On Fri, 2024-08-09 at 15:32 +0300, Ceclan, Dumitru wrote:
> On 09/08/2024 15:26, Nuno Sá wrote:
> > On Fri, 2024-08-09 at 13:33 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> > >
> > > This commit adds support for the AD4113 ADC.
> > > The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> > > converter (ADC) that integrates an analog front end (AFE) for four
> > > fully differential or eight single-ended inputs.
> > >
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> > > ---
> >
> > Any reason to drop my tag :)? There a b4 command that can help you with it.
> >
> > - Nuno Sá
> >
> >
>
> Yes, I added a new field to the device info struct and changed dt parsing
> because I missed in V1 that this model actually has a 16 bit data register.
> I considered that the rb would not apply anymore and it would need a re-review.
>
> Thanks for the b4 suggestion but this was intentional :))
Got it. Next time mention that in the cover...
Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>