Re: [PATCH] arm: Fix build issue with LD_DEAD_CODE_DATA_ELIMINATION

[Arnd Bergmann]

On Thu, Aug 8, 2024, at 14:35, Yuntao Liu wrote:
> There is a build issue with LD segmentation fault, while
> CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled, as bellow.
>
> scripts/link-vmlinux.sh: line 49:  3796 Segmentation fault
>  (core dumped) ${ld} ${ldflags} -o ${output} ${wl}--whole-archive
>  ${objs} ${wl}--no-whole-archive ${wl}--start-group
>  ${libs} ${wl}--end-group ${kallsymso} ${btf_vmlinux_bin_o} ${ldlibs}
>
> The error occurs in older versions of the GNU ld with version earlier
> than 2.36. It makes most sense to have a minimum LD version as
> a dependency for HAVE_LD_DEAD_CODE_DATA_ELIMINATION and eliminate
> the impact of ".reloc  .text, R_ARM_NONE, ." when
> CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled.
>
> Fixes: ed0f94102251 ("ARM: 9404/1: arm32: enable 
> HAVE_LD_DEAD_CODE_DATA_ELIMINATION")
> Reported-by: Harith George <mail2hgg@xxxxxxxxx>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Yuntao Liu <liuyuntao12@xxxxxxxxxx>
> Link: 
> https://lore.kernel.org/all/14e9aefb-88d1-4eee-8288-ef15d4a9b059@xxxxxxxxx/

Looks good to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>