Re: [PATCH v2 1/2] dt-bindings: adc: ad7173: add support for ad4113
From: Conor Dooley
Date: Fri Aug 09 2024 - 11:09:21 EST
On Fri, Aug 09, 2024 at 05:32:08PM +0300, Ceclan, Dumitru wrote:
> On 09/08/2024 17:21, Conor Dooley wrote:
> > On Fri, Aug 09, 2024 at 01:33:24PM +0300, Dumitru Ceclan via B4 Relay wrote:
> >> From: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> >>
> >> This commit adds bindings support for AD4113.
> >>
> >> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> >> converter (ADC) that integrates an analog front end (AFE) for four
> >> fully differential or eight single-ended inputs.
> >>
> >> Added ad4113 to the compatible list and the "avdd2-supply: false"
> >> restriction.
> >>
> >> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@xxxxxxxxxx>
> >> ---
> >> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> >> index 17c5d39cc2c1..ad15cf9bc2ff 100644
> >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> >> @@ -28,6 +28,7 @@ description: |
> >> Datasheets for supported chips:
> >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf
> >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf
> >> + <AD4113: not released yet>
> >
> > Am I meant to ack it with this placeholder? When will the document be
> > released?
> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> >
> Not really sure tbh, up to you. The document will be released in the upcoming months.
>
> If it's considered best to wait until the docs are public and send another
> version with the correct link.
> If not, and maintainers consider that these changes can be accepted even
> without viewing the datasheet, I'll send a patch when it goes public.
I don't really care, it's just to Jonathan I think. I'm happy enough
with you adding it when it is released.
Attachment:
signature.asc
Description: PGP signature