Re: [PATCH v3 3/3] nbd: correct the maximum value for discard sectors

From: Jens Axboe
Date: Fri Aug 09 2024 - 11:35:06 EST


On 8/8/24 1:06 AM, Wouter Verhelst wrote:
> The version of the NBD protocol implemented by the kernel driver
> currently has a 32 bit field for length values. As the NBD protocol uses
> bytes as a unit of length, length values larger than 2^32 bytes cannot
> be expressed.
>
> Update the max_hw_discard_sectors field to match that.
>
> Signed-off-by: Wouter Verhelst <w@xxxxxxx>
> Fixes: 268283244c0f018dec8bf4a9c69ce50684561f46

This isn't the correct way to have a fixes line.

In general, please don't nest next versions under the previous posting,
and it's strongly recommended to have a cover letter that includes that
changed from version N to N+1. Otherwise we have to guess... So please
include that when posting v4.

--
Jens Axboe