Re: [PATCH v1] ACPI: APD: Add AMDI0015 as platform device

[Andy Shevchenko]

On Fri, Aug 09, 2024 at 09:08:22PM +0530, Shyam Sundar S K wrote:
> +Andy
> 
> On 7/18/2024 20:53, Shyam Sundar S K wrote:
> > Add AMDI0015 to the ACPI APD support list to ensure correct clock settings
> > for the I3C device on the latest AMD platforms.

...

> >  	{ "AMD0040", APD_ADDR(fch_misc_desc)},
> >  	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
> >  	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
> > +	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },

Please, keep it sorted.

...

> FYI..

Thanks!

> AMDI0015 is for MIPI I3C (we call it I3C legacy) version of the
> implementation.
> 
> and.. MIPI0100 is for HCI based implementation of the MIPI I3C
> Specification.

This is fine as long as there is no collision, i.e. if a new (HCI I3C _HID is
required the new one should be allocated).

-- 
With Best Regards,
Andy Shevchenko