Re: [PATCH V2 09/10] accel/amdxdna: Add query functions

[Jeffrey Hugo]

On 8/5/2024 11:39 AM, Lizhi Hou wrote:
> +/**
> + * struct amdxdna_drm_query_hwctx - The data for single context.
> + * @context_id: The ID for this context.
> + * @start_col: The starting column for the partition assigned to this context.
> + * @num_col: The number of columns in the partition assigned to this context.
> + * @pid: The Process ID of the process that created this context.
> + * @command_submissions: The number of commands submitted to this context.
> + * @command_completions: The number of commands completed by this context.
> + * @migrations: The number of times this context has been moved to a different partition.
> + * @preemptions: The number of times this context has been preempted by another context in the
> + *               same partition.
> + * @pad: MBZ.

Did you make the documentation?  This looks like it'll generate errors 
from missing fields, and not having the same order as the struct.

> + */
> +struct amdxdna_drm_query_hwctx {
> +	__u32 context_id;
> +	__u32 start_col;
> +	__u32 num_col;
> +	__u32 pad;
> +	__s64 pid;
> +	__u64 command_submissions;
> +	__u64 command_completions;
> +	__u64 migrations;
> +	__u64 preemptions;
> +	__u64 errors;
> +};