Re: [PATCH 1/1] Net: bcm.c: Remove Subtree Instead of Entry

[Kuniyuki Iwashima]

From: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
Date: Fri, 9 Aug 2024 13:22:49 -0700
> From: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
> Date: Fri, 9 Aug 2024 11:57:41 +0200
> > Hello David,
> > 
> > many thanks for the patch and the description.
> > 
> > Btw. the data structures of the elements inside that bcm proc dir should 
> > have been removed at that point, so that the can-bcm dir should be empty.
> > 
> > I'm not sure what happens to the open sockets that are (later) removed 
> > in bcm_release() when we use remove_proc_subtree() as suggested. 
> > Removing this warning probably does not heal the root cause of the issue.
> 
> I posted a patch to fix bcm's proc entry leak few weeks ago, and this might
> be related.
> https://lore.kernel.org/netdev/20240722192842.37421-1-kuniyu@xxxxxxxxxx/

I just noticed the syzbot report that David pointed out has the same
splat, so this is the same issue that my patch fixes.

https://syzkaller.appspot.com/bug?extid=df49d48077305d17519a