Re: [PATCH v3] rust: Kbuild: Skip -fmin-function-alignment in bindgen flags

[Miguel Ojeda]

On Wed, Jul 31, 2024 at 3:45 PM Zehui Xu <zehuixu@xxxxxxxxxx> wrote:
>
> GCC 14 recently added -fmin-function-alignment option and the
> root Makefile uses it to replace -falign-functions when available.
> However, this flag can cause issues when passed to the Rust
> Makefile and affect the bindgen process. Bindgen relies on
> libclang to parse C code, and currently does not support the
> -fmin-function-alignment flag, leading to compilation failures
> when GCC 14 is used.
>
> This patch addresses the issue by adding -fmin-function-alignment
> to the bindgen_skip_c_flags in rust/Makefile. This prevents the
> flag from causing compilation issues.
>
> Link: https://lore.kernel.org/linux-kbuild/20240222133500.16991-1-petr.pavlu@xxxxxxxx/
> Signed-off-by: Zehui Xu <zehuixu@xxxxxxxxxx>

Applied to `rust-fixes` -- thanks everyone!

    [ Matthew and Gary confirm function alignment should not change
      the ABI in a way that bindgen would care about, thus we did
      not need the extra logic for bindgen from v2. - Miguel ]

    [ Reworded title. - Miguel ]

Cheers,
Miguel