Re: [PATCH 3/3] platform/surface: Add OF support

From: Konrad Dybcio
Date: Fri Aug 09 2024 - 19:09:52 EST


On 9.08.2024 3:48 AM, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx>
>
> Add basic support for registering the aggregator module on Device Tree-
> based platforms. These include at least three generations of Qualcomm
> Snapdragon-based Surface devices:
>
> - SC8180X / SQ1 / SQ2: Pro X,
> - SC8280XP / SQ3: Devkit 2023, Pro 9
> - X Elite: Laptop 7 / Pro11
>
> Thankfully, the aggregators on these seem to be configured in an
> identical way, which allows for using these settings as defaults and
> no DT properties need to be introduced (until that changes, anyway).
>
> Based on the work done by Maximilian Luz, largely rewritten.
>
> Signed-off-by: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx>
> ---

[...]

> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -2444,7 +2444,8 @@ static int acpi_walk_dep_device_list(acpi_handle handle,
> */
> void acpi_dev_clear_dependencies(struct acpi_device *supplier)
> {
> - acpi_walk_dep_device_list(supplier->handle, acpi_scan_clear_dep, NULL);
> + if (supplier)
> + acpi_walk_dep_device_list(supplier->handle, acpi_scan_clear_dep, NULL);
> }
> EXPORT_SYMBOL_GPL(acpi_dev_clear_dependencies);

Err this shouldn't have made it into this patch

Konrad