Re: [PATCH v2 2/2] iio: imu: smi240: imu driver

[Krzysztof Kozlowski]

On 09/08/2024 14:18, Shen Jianping (ME-SE/EAD2) wrote:
> Hi Christophe,
> 
> ....
>> +
>> +	data = iio_priv(indio_dev);
>> +	dev_set_drvdata(dev, indio_dev);
>> +	data->regmap = regmap;
>> +	data->capture = 0;
> 
> No need to explicitly initialize 'capture', devm_iio_device_alloc() already zeroes the allocated emmory.
> It doesn't hurt to be explicit, but why this field and not the other ones?
> 
> -> This is the flag to enable capture mode. It is important to be disabled by default, therefore rather make this explicitly.

It's redundant.

Anyway, it's not suppose to be uint8 anyway, but bool or enum.

Best regards,
Krzysztof