Re: [PATCH 2/6] kbuild: rust: make command for `RUSTC_VERSION_TEXT` closer to the `CC` one

From: Miguel Ojeda
Date: Sat Aug 10 2024 - 10:45:37 EST


On Sat, Aug 10, 2024 at 3:44 PM Björn Roy Baron
<bjorn3_gh@xxxxxxxxxxxxxx> wrote:
>
> Cargo depends on the rustc version string not getting localized. Or to be precise it depends on the version string being fixed for a given rustc version, which would not be the case if the value of LC_ALL could change the version string. If the version string changes, cargo will rebuild everything from scratch. There is also not really anything to localize in the non-verbose version string. I guess setting LC_ALL doesn't hurt either though.

Thanks Björn -- yeah, I agree it works either way (also for `head` as
Masahiro mentioned).

I made this commit to make it as close as possible to the C one, since
in the next patch it gets moved to another place where both commands
go together.

It is reasonable to argue that it makes it more complex and slower, so
I am happy dropping it.

Cheers,
Miguel