Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: add missed property phys
From: Frank Li
Date: Sat Aug 10 2024 - 17:57:01 EST
On Sat, Aug 10, 2024 at 01:46:25PM +0200, Krzysztof Kozlowski wrote:
> On 09/08/2024 22:06, Frank Li wrote:
> > Add missed property phys, which indicate how connect to serdes phy.
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: dpmacs:ethernet@7: Unevaluated properties are not allowed ('phys' was unexpected)
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > index 6538e0ce90b28..25d657be6956f 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> > @@ -38,6 +38,10 @@ properties:
> >
> > managed: true
> >
> > + phys:
> > + description: A reference to the SerDes lane(s)
>
> This is not the same phy as phy-handle points to?
I go through source code and dts, it is not the same. phys connect to chip
internal serdas phys. phy-handle points to external ethernet phy, which is
connected by mdio bus generally.
Frank
>
> Best regards,
> Krzysztof
>