[PATCH 5/5] net: qcom/emac: Prevent device_find_child() from modifying caller's match data

From: Zijun Hu
Date: Sat Aug 10 2024 - 20:20:24 EST


From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>

It does not make sense for emac_sgmii_acpi_match() as device_find_child()'s
match function to modify caller's match data, fixed by using
constify_device_find_child_helper() instead of device_find_child().

Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
---
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
index e4bc18009d08..e53065756a1d 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
@@ -358,8 +358,9 @@ int emac_sgmii_config(struct platform_device *pdev, struct emac_adapter *adpt)
if (has_acpi_companion(&pdev->dev)) {
struct device *dev;

- dev = device_find_child(&pdev->dev, &phy->sgmii_ops,
- emac_sgmii_acpi_match);
+ dev = constify_device_find_child_helper(&pdev->dev,
+ &phy->sgmii_ops,
+ emac_sgmii_acpi_match);

if (!dev) {
dev_warn(&pdev->dev, "cannot find internal phy node\n");

--
2.34.1