Re: [PATCH v2 3/3] platform/surface: Add OF support

From: Maximilian Luz
Date: Sat Aug 10 2024 - 20:26:51 EST


On 8/10/24 3:28 AM, Konrad Dybcio wrote:
From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx>

[...]

@@ -346,7 +359,7 @@ static const struct software_node *ssam_node_group_sp9[] = {
/* -- SSAM platform/meta-hub driver. ---------------------------------------- */
-static const struct acpi_device_id ssam_platform_hub_match[] = {
+static const struct acpi_device_id ssam_platform_hub_acpi_match[] = {
/* Surface Pro 4, 5, and 6 (OMBR < 0x10) */
{ "MSHW0081", (unsigned long)ssam_node_group_gen5 },
@@ -402,16 +415,39 @@ static const struct acpi_device_id ssam_platform_hub_match[] = {
};
MODULE_DEVICE_TABLE(acpi, ssam_platform_hub_match);

This should be

MODULE_DEVICE_TABLE(acpi, ssam_platform_hub_acpi_match);

as it has been renamed above. In addition to this, the
surface_aggregator_registry module currently does not auto-load. So we
also need to add

MODULE_ALIAS("platform:surface_aggregator_platform_hub");

somewhere. With that fixed, it builds and runs fine on the SPX.

Best regards,
Max