Re: [PATCH] padata: Fix possible divide-by-0 panic in padata_mt_helper()
From: Herbert Xu
Date: Sat Aug 10 2024 - 23:41:41 EST
On Sat, Aug 10, 2024 at 11:27:55PM -0400, Waiman Long wrote:
>
> Now I see what you mean. Yes, we can probably change that to a DIV_ROUND_UP
> operation to make sure that chunk_size is at least one unless job->size is
> 0. I still think the current patch is a bit more fail-safe.
The very first thing the function does is check that job->size is
not zero. So this should be all that is necessary.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt