Re: [PATCH net-next v4 2/3] phy: Add Open Alliance helpers for the PHY framework

[Andrew Lunn]

On Sun, Aug 11, 2024 at 10:21:44AM +0100, Russell King (Oracle) wrote:
> On Sun, Aug 11, 2024 at 07:20:04AM +0200, Oleksij Rempel wrote:
> > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
> > index 202ed7f450da6..e93dfec881c5d 100644
> > --- a/drivers/net/phy/Makefile
> > +++ b/drivers/net/phy/Makefile
> > @@ -23,6 +23,7 @@ obj-$(CONFIG_MDIO_DEVRES)	+= mdio_devres.o
> >  libphy-$(CONFIG_SWPHY)		+= swphy.o
> >  libphy-$(CONFIG_LED_TRIGGER_PHY)	+= phy_led_triggers.o
> >  
> > +obj-$(CONFIG_OPEN_ALLIANCE_HELPERS) += open_alliance_helpers.o
> 
> I was thinking more
> libphy-$(CONFIG_OPEN_ALLIANCE_HELPERS) += open_alliance_helpers.o
> 
> rather than a potentially separate module.
> 
> If it is going to end up a separate module, then it needs its own
> MODULE_LICENSE, MODULE_DESCRIPTION, etc.

I'm happy either way.

	Andrew