RE: [PATCH net-next v3 3/3] net: fec: make PPS channel configurable
From: Wei Fang
Date: Sun Aug 11 2024 - 22:37:57 EST
> -----Original Message-----
> From: Francesco Dolcini <francesco@xxxxxxxxxx>
> Sent: 2024年8月9日 17:48
> To: Wei Fang <wei.fang@xxxxxxx>; Shenwei Wang
> <shenwei.wang@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>; David S.
> Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>;
> Richard Cochran <richardcochran@xxxxxxxxx>
> Cc: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>; imx@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Frank Li
> <frank.li@xxxxxxx>; Rafael Beims <rafael.beims@xxxxxxxxxxx>
> Subject: [PATCH net-next v3 3/3] net: fec: make PPS channel configurable
>
> From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
>
> Depending on the SoC where the FEC is integrated into the PPS channel might
> be routed to different timer instances. Make this configurable from the
> devicetree.
>
> When the related DT property is not present fallback to the previous default
> and use channel 0.
>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Tested-by: Rafael Beims <rafael.beims@xxxxxxxxxxx>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> ---
> v3: added net-next subject prefix
> v2: add Reviewed|Tested-by
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 25f988b9c7cf..2e05083cbf29 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -529,8 +529,6 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp,
> unsigned long flags;
> int ret = 0;
>
> - fep->pps_channel = DEFAULT_PPS_CHANNEL;
> -
> if (rq->type == PTP_CLK_REQ_PPS) {
> fep->reload_period = PPS_OUPUT_RELOAD_PERIOD;
>
> @@ -712,12 +710,16 @@ void fec_ptp_init(struct platform_device *pdev, int
> irq_idx) {
> struct net_device *ndev = platform_get_drvdata(pdev);
> struct fec_enet_private *fep = netdev_priv(ndev);
> + struct device_node *np = fep->pdev->dev.of_node;
nit
struct device_node *np = pdev->dev.of_node;
> int irq;
> int ret;
>
> fep->ptp_caps.owner = THIS_MODULE;
> strscpy(fep->ptp_caps.name, "fec ptp", sizeof(fep->ptp_caps.name));
>
> + fep->pps_channel = DEFAULT_PPS_CHANNEL;
> + of_property_read_u32(np, "fsl,pps-channel", &fep->pps_channel);
> +
> fep->ptp_caps.max_adj = 250000000;
> fep->ptp_caps.n_alarm = 0;
> fep->ptp_caps.n_ext_ts = 0;
> --
> 2.39.2