Re: [Patch v3 0/5] Bug fixes on topdown events reordering

From: Mi, Dapeng
Date: Mon Aug 12 2024 - 01:43:53 EST


Hi Ian,

Kindly ping, any comments here? Thanks.

On 7/13/2024 1:03 AM, Dapeng Mi wrote:
> Changes:
> v2 -> v3:
> * Refine arch_is_topdown_metrics() (Kan Liang)
> * Only move topdown metric events forward when they are not in the
> group with previous event (Ian)
> * Check if topdown events is supported before test topown events
> leader sampling (Kan Liang)
>
> History:
> v1: https://lore.kernel.org/all/20240702224037.343958-1-dapeng1.mi@xxxxxxxxxxxxxxx/
> v2: https://lore.kernel.org/all/20240708144204.839486-1-dapeng1.mi@xxxxxxxxxxxxxxx/
>
>
> Dapeng Mi (5):
> perf x86/topdown: Complete topdown slots/metrics events check
> perf x86/topdown: Correct leader selection with sample_read enabled
> perf x86/topdown: Don't move topdown metric events in group
> perf tests: Add leader sampling test in record tests
> perf tests: Add topdown events counting and sampling tests
>
> tools/perf/arch/x86/util/evlist.c | 13 +++++--
> tools/perf/arch/x86/util/evsel.c | 3 +-
> tools/perf/arch/x86/util/topdown.c | 62 +++++++++++++++++++++++++++++-
> tools/perf/arch/x86/util/topdown.h | 2 +
> tools/perf/tests/shell/record.sh | 45 ++++++++++++++++++++++
> tools/perf/tests/shell/stat.sh | 6 +++
> 6 files changed, 124 insertions(+), 7 deletions(-)
>
>
> base-commit: 73e931504f8e0d42978bfcda37b323dbbd1afc08