Re: [PATCH v6 0/4 RESEND] media: mgb4: YUV and variable framerate support
From: Hans Verkuil
Date: Mon Aug 12 2024 - 02:53:17 EST
Hi Martin,
Before I merge this series, I would like to see the v4l2-compliance output for
each video device.
Can you reply with that output?
I want to make sure that all the g/s_parm and dv_timings changes are correct
according to v4l2-compliance. And of course, if it isn't, then please fix
any reported issue and post a v7.
Regards,
Hans
On 05/08/2024 17:40, tumic@xxxxxxxxxx wrote:
> From: Martin Tůma <martin.tuma@xxxxxxxxxxxxxxxxxxxxx>
>
> Recent mgb4 FW update added support for the YUV image format and variable
> framerates independent of the signal framerate. The following patches extend
> the mgb4 driver with support for both features.
>
> Changes in V6:
> - Properly handle the timings when no signal is present.
>
> Changes in V5:
> - Removed surplus v4l2_format.type checks.
> - Improved the patch descriptions.
> - Splitted the frame rate limit patch into separate code/documentation parts.
>
> Changes in V4:
> - Splitted the output frame_rate handling fix from the variable frame rate
> addition patch.
>
> Changes in V3:
> - Use div_u64() for 64b division (fixes build error on ARM32)
>
> Changes in V2:
> - Added missing stride limit
>
> Martin Tůma (4):
> media: mgb4: Add support for YUV image formats
> media: mgb4: Add support for V4L2_CAP_TIMEPERFRAME
> media: mgb4: Fixed signal frame rate limit handling
> media: admin-guide: mgb4: Outputs DV timings documentation update
>
> Documentation/admin-guide/media/mgb4.rst | 23 +-
> drivers/media/pci/mgb4/mgb4_core.c | 2 +-
> drivers/media/pci/mgb4/mgb4_core.h | 2 +
> drivers/media/pci/mgb4/mgb4_io.h | 29 ++-
> drivers/media/pci/mgb4/mgb4_sysfs_out.c | 9 +-
> drivers/media/pci/mgb4/mgb4_vin.c | 193 +++++++++++---
> drivers/media/pci/mgb4/mgb4_vin.h | 3 +-
> drivers/media/pci/mgb4/mgb4_vout.c | 309 ++++++++++++++++++++---
> drivers/media/pci/mgb4/mgb4_vout.h | 5 +-
> 9 files changed, 482 insertions(+), 93 deletions(-)
>
>
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0