Re: [PATCH net-next v2] mptcp: correct MPTCP_SUBFLOW_ATTR_SSN_OFFSET reserved size

[Matthieu Baerts]

Hi Eugene, Network maintainers,

On 12/08/2024 08:51, Eugene Syromiatnikov wrote:
> ssn_offset field is u32 and is placed into the netlink response with
> nla_put_u32(), but only 2 bytes are reserved for the attribute payload
> in subflow_get_info_size() (even though it makes no difference
> in the end, as it is aligned up to 4 bytes).  Supply the correct
> argument to the relevant nla_total_size() call to make it less
> confusing.
> 
> Fixes: 5147dfb50832 ("mptcp: allow dumping subflow context to userspace")
> Signed-off-by: Eugene Syromiatnikov <esyr@xxxxxxxxxx>
> ---
> v2:
>   - Added prefix to the patch subject
>   - Fixed commit message formatting (line width, "Fixes:" commit hash
>     prefix size)

Thank you for the v2!

The patch looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>

Because it is a fix, I think it is a candidate for -net, not net-next.

@Network maintainers: is it OK for you to apply this v2 in "net", not
"net-next"? Or is it easier for you to have a v3 with a different prefix?

(No conflicts to apply this patch on -net, the code didn't change for 4
years.)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.