Re: [PATCH 00/10] platform: x86: Use backlight power constants

From: Hans de Goede
Date: Mon Aug 12 2024 - 10:30:06 EST


Hi,

On 7/31/24 2:50 PM, Thomas Zimmermann wrote:
> Commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for
> power states") introduced dedicated constants for backlight power states.
> Convert X86 platform drivers to the new constants.
>
> The new constants replace the fbdev constants. This is part of a larger
> effort to make kernel subsystems more independent from fbdev code and
> headers.
>
> Thomas Zimmermann (10):
> platform/x86: acer-wmi: Use backlight power constants
> platform/x86: asus-laptop: Use backlight power constants
> platform/x86: asus-nb-wmi: Use backlight power constants
> platform/x86: asus-wmi: Use backlight power constants
> platform/x86: eeepc-laptop: Use backlight power constants
> platform/x86: eeepc-wmi: Use backlight power constants
> platform/x86: fujitsu-laptop: Use backlight power constants
> platform/x86: ideapad-laptop: Use backlight power constants
> platform/x86: oaktrail: Use backlight power constants
> platform/x86: samsung-laptop: Use backlight power constants

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans





> drivers/platform/x86/acer-wmi.c | 3 +--
> drivers/platform/x86/asus-laptop.c | 3 +--
> drivers/platform/x86/asus-nb-wmi.c | 4 ++--
> drivers/platform/x86/asus-wmi.c | 17 ++++++++---------
> drivers/platform/x86/eeepc-laptop.c | 3 +--
> drivers/platform/x86/eeepc-wmi.c | 4 ++--
> drivers/platform/x86/fujitsu-laptop.c | 9 ++++-----
> drivers/platform/x86/ideapad-laptop.c | 7 +++----
> drivers/platform/x86/intel/oaktrail.c | 3 +--
> drivers/platform/x86/samsung-laptop.c | 5 ++---
> 10 files changed, 25 insertions(+), 33 deletions(-)
>