Re: [PATCH net v2] libceph: Make the arguments const as per the TODO
From: kernel test robot
Date: Mon Aug 12 2024 - 11:26:43 EST
Hi Abhinav,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Abhinav-Jain/libceph-Make-the-arguments-const-as-per-the-TODO/20240812-045647
base: net/main
patch link: https://lore.kernel.org/r/20240811205509.1089027-1-jain.abhinav177%40gmail.com
patch subject: [PATCH net v2] libceph: Make the arguments const as per the TODO
config: i386-buildonly-randconfig-002-20240812 (https://download.01.org/0day-ci/archive/20240812/202408121938.QL7KtnzW-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240812/202408121938.QL7KtnzW-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408121938.QL7KtnzW-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> net/ceph/crypto.c:93:19: error: passing 'const void **' to parameter of type 'void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
93 | ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad);
| ^
include/linux/ceph/decode.h:59:29: note: expanded from macro 'ceph_decode_need'
59 | if (!likely(ceph_has_room(p, end, n))) \
| ^
include/linux/compiler.h:76:40: note: expanded from macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/ceph/decode.h:52:41: note: passing argument to parameter 'p' here
52 | static inline bool ceph_has_room(void **p, void *end, size_t n)
| ^
>> net/ceph/crypto.c:93:22: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
93 | ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad);
| ^~~
include/linux/ceph/decode.h:59:32: note: expanded from macro 'ceph_decode_need'
59 | if (!likely(ceph_has_room(p, end, n))) \
| ^~~
include/linux/compiler.h:76:40: note: expanded from macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/ceph/decode.h:52:50: note: passing argument to parameter 'end' here
52 | static inline bool ceph_has_room(void **p, void *end, size_t n)
| ^
net/ceph/crypto.c:94:29: error: passing 'const void **' to parameter of type 'void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
94 | key->type = ceph_decode_16(p);
| ^
include/linux/ceph/decode.h:31:41: note: passing argument to parameter 'p' here
31 | static inline u16 ceph_decode_16(void **p)
| ^
net/ceph/crypto.c:95:19: error: passing 'const void **' to parameter of type 'void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
95 | ceph_decode_copy(p, &key->created, sizeof(key->created));
| ^
include/linux/ceph/decode.h:43:44: note: passing argument to parameter 'p' here
43 | static inline void ceph_decode_copy(void **p, void *pv, size_t n)
| ^
net/ceph/crypto.c:96:28: error: passing 'const void **' to parameter of type 'void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
96 | key->len = ceph_decode_16(p);
| ^
include/linux/ceph/decode.h:31:41: note: passing argument to parameter 'p' here
31 | static inline u16 ceph_decode_16(void **p)
| ^
net/ceph/crypto.c:97:19: error: passing 'const void **' to parameter of type 'void **' discards qualifiers in nested pointer types [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
97 | ceph_decode_need(p, end, key->len, bad);
| ^
include/linux/ceph/decode.h:59:29: note: expanded from macro 'ceph_decode_need'
59 | if (!likely(ceph_has_room(p, end, n))) \
| ^
include/linux/compiler.h:76:40: note: expanded from macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/ceph/decode.h:52:41: note: passing argument to parameter 'p' here
52 | static inline bool ceph_has_room(void **p, void *end, size_t n)
| ^
net/ceph/crypto.c:97:22: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
97 | ceph_decode_need(p, end, key->len, bad);
| ^~~
include/linux/ceph/decode.h:59:32: note: expanded from macro 'ceph_decode_need'
59 | if (!likely(ceph_has_room(p, end, n))) \
| ^~~
include/linux/compiler.h:76:40: note: expanded from macro 'likely'
76 | # define likely(x) __builtin_expect(!!(x), 1)
| ^
include/linux/ceph/decode.h:52:50: note: passing argument to parameter 'end' here
52 | static inline bool ceph_has_room(void **p, void *end, size_t n)
| ^
net/ceph/crypto.c:98:24: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
98 | ret = set_secret(key, *p);
| ^~
net/ceph/crypto.c:23:58: note: passing argument to parameter 'buf' here
23 | static int set_secret(struct ceph_crypto_key *key, void *buf)
| ^
net/ceph/crypto.c:99:19: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
99 | memzero_explicit(*p, key->len);
| ^~
include/linux/string.h:356:43: note: passing argument to parameter 's' here
356 | static inline void memzero_explicit(void *s, size_t count)
| ^
9 errors generated.
vim +93 net/ceph/crypto.c
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 88
19c7b44529ef1b net/ceph/crypto.c Abhinav Jain 2024-08-12 89 int ceph_crypto_key_decode(struct ceph_crypto_key *key, const void **p, const void *end)
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 90 {
7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 91 int ret;
7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 92
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 @93 ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad);
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 94 key->type = ceph_decode_16(p);
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 95 ceph_decode_copy(p, &key->created, sizeof(key->created));
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 96 key->len = ceph_decode_16(p);
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 97 ceph_decode_need(p, end, key->len, bad);
7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 98 ret = set_secret(key, *p);
10f42b3e648377 net/ceph/crypto.c Ilya Dryomov 2020-12-22 99 memzero_explicit(*p, key->len);
7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 100 *p += key->len;
7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 101 return ret;
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 102
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 103 bad:
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 104 dout("failed to decode crypto key\n");
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 105 return -EINVAL;
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 106 }
8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 107
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki