Re: [PATCH] kgdbts: fix hw_access_break_test

[Doug Anderson]

Hi,

On Mon, Aug 12, 2024 at 1:55 AM Florian Rommel <mail@xxxxxxxxxxxx> wrote:
>
> The test for access watchpoints (hw_access_break_test) was broken
> (always failed) because the compiler optimized out the write to the
> static helper variable (hw_break_val2), as it is never read anywhere.
> This resulted in the target variable (hw_break_val) not being accessed
> and thus the breakpoint not being triggered.
>
> Remove the helper variable (hw_break_val2), and use READ_ONCE to force
> reading the target variable (hw_break_val).
>
> Signed-off-by: Florian Rommel <mail@xxxxxxxxxxxx>
> ---
>  drivers/misc/kgdbts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>