Re: [PATCH v1] perf inject: Inject build ids for entire call chain

[Ian Rogers]

On Fri, Aug 2, 2024 at 11:23 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Hi Ian,
>
> On Wed, Jul 31, 2024 at 08:12:49PM -0700, Ian Rogers wrote:
> > The DSO build id is injected when the dso is first encountered but the
> > checking for first encountered only looks at the sample->ip not the
> > entire callchain. Use the callchain logic to ensure all build ids are
> > inserted.
> >
> > Add a for_each callback style API to callchain with
> > sample__for_each_callchain_node. Possibly in the future such an API
> > can avoid the overhead of constructing the call chain list.
> >
> > Fixes: 454c407ec17a ("perf: add perf-inject builtin")
> > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Ping.

Thanks,
Ian