Re: [PATCH v1] perf inject: Fix leader sampling inserting additional samples

From: Arnaldo Carvalho de Melo
Date: Mon Aug 12 2024 - 16:57:06 EST


On Mon, Aug 12, 2024 at 01:37:36PM -0700, Ian Rogers wrote:
> On Wed, Jul 31, 2024 at 11:21 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > > This behavior is incorrect as in the case above perf inject should
> > > have done nothing. Fix this behavior by disabling separating samples
> > > for a tool that requests it. Only request this for `perf inject` so as
> > > to not affect other perf tools. With the patch and the test above
> > > there are no differences between the orig.txt and new.txt.

> > > Fixes: e4caec0d1af3 ("perf evsel: Add PERF_SAMPLE_READ sample related processing")
> > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

> > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

> Ping.

Thanks, applied to perf-tools-next,

- Arnaldo