Re: [PATCH] scsi: fix the return value of scsi_logical_block_count
From: Martin K. Petersen
Date: Mon Aug 12 2024 - 21:53:39 EST
Chaotian,
> @@ -236,7 +236,7 @@ static inline unsigned int scsi_logical_block_count(struct scsi_cmnd *scmd)
> {
> unsigned int shift = ilog2(scmd->device->sector_size) - SECTOR_SHIFT;
>
> - return blk_rq_bytes(scsi_cmd_to_rq(scmd)) >> shift;
> + return blk_rq_sectors(scsi_cmd_to_rq(scmd)) >> shift;
> }
There's no point in shifting twice by converting to sectors first.
Please just remove the SECTOR_SHIFT subtraction.
--
Martin K. Petersen Oracle Linux Engineering