Re: [PATCH net-next v2 3/7] net: ti: icssg-prueth: Stop hardcoding def_inc
From: Dan Carpenter
Date: Tue Aug 13 2024 - 04:07:03 EST
On Tue, Aug 13, 2024 at 01:12:29PM +0530, MD Danish Anwar wrote:
> The def_inc is stored in icss_iep structure. Currently default increment
> (ns per clock tick) is hardcoded to 4 (Clock frequency being 250 MHz).
> Change this to use the iep->def_inc variable as the iep structure is now
> accessible to the driver files.
>
> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx>
> ---
Thanks for breaking this out into a separate patch and removing the unused
spinlock. I don't necessarily feel qualified to review this patchset but I
didn't have any other issues with it.
regards,
dan carpenter