Re: [PATCH] platform/surface: aggregator: Fix warning when controller is destroyed in probe

From: Ilpo Järvinen
Date: Tue Aug 13 2024 - 04:23:32 EST


On Sun, 11 Aug 2024 14:46:44 +0200, Maximilian Luz wrote:

> There is a small window in ssam_serial_hub_probe() where the controller
> is initialized but has not been started yet. Specifically, between
> ssam_controller_init() and ssam_controller_start(). Any failure in this
> window, for example caused by a failure of serdev_device_open(),
> currently results in an incorrect warning being emitted.
>
> In particular, any failure in this window results in the controller
> being destroyed via ssam_controller_destroy(). This function checks the
> state of the controller and, in an attempt to validate that the
> controller has been cleanly shut down before we try and deallocate any
> resources, emits a warning if that state is not SSAM_CONTROLLER_STOPPED.
>
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/surface: aggregator: Fix warning when controller is destroyed in probe
commit: bc923d594db21bee0ead128eb4bb78f7e77467a4

--
i.