Re: [PATCH v2 3/3] regmap: Allow setting IRQ domain name suffix

[Matti Vaittinen]

On 8/12/24 22:05, Andy Shevchenko wrote:
> On Thu, Aug 08, 2024 at 03:36:28PM +0300, Matti Vaittinen wrote:
> > When multiple IRQ domains are created from the same device-tree node they
> > will get the same name based on the device-tree path. This will cause a
> > naming collision in debugFS when IRQ domain specific entries are created.
> >
> > The regmap-IRQ creates per instance IRQ domains. This will lead to a
> > domain name conflict when a device which provides more than one
> > interrupt line uses the regmap-IRQ.
> >
> > Add support for specifying an IRQ domain name suffix when creating a
> > regmap-IRQ controller.
>
> ...
>
> > +static int regmap_irq_create_domain(struct fwnode_handle *fwnode, int irq_base,
> > +				    const struct regmap_irq_chip *chip,
> > +				    struct regmap_irq_chip_data *d)
> > +{
> > +	struct irq_domain_info info = {
> > +		.fwnode = fwnode,
> > +		.size = chip->num_irqs,
> > +		.hwirq_max = chip->num_irqs,
> > +		.virq_base = irq_base,
> > +		.ops = &regmap_domain_ops,
> > +		.host_data = d,
> > +		.name_suffix = chip->domain_suffix,
> > +	};
> > +
> > +	d->domain = irq_domain_instantiate(&info);
> > +	if (IS_ERR(d->domain)) {
> > +		dev_err(d->map->dev, "Failed to create IRQ domain\n");
> > +		return PTR_ERR(d->domain);
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> > +
>
> One blank line is enough?

Sure. Thanks Andy!

Yours,
	--Matti

> >   /**

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~