Re: [PATCH v2 1/2] uprobes: Remove redundant spinlock in uprobe_deny_signal()

From: Oleg Nesterov
Date: Tue Aug 13 2024 - 08:48:13 EST


On 08/13, Liao, Chang wrote:
>
>
> Oleg, your explaination is more accurate. So I will reword the commit log and
> quote some of your note like this:

Oh, please don't. I just tried to explain the history of this spin_lock(siglock).

> Since we already have the lockless user of clear_thread_flag(TIF_SIGPENDING).
> And for uprobe singlestep case, it doesn't break the rule of "the state of
> TIF_SIGPENDING of every thread is stable with sighand->siglock held".

It obviously does break the rule above. Please keep your changelog as is.

Oleg.