Re: [PATCH 3/6] media: i2c: s5c73m3: Move clk_prepare to its own function
From: Dan Carpenter
Date: Tue Aug 13 2024 - 08:59:30 EST
On Tue, Aug 13, 2024 at 12:13:50PM +0000, Ricardo Ribalda wrote:
> Smatch is very confused by a clk_prepare_enable() being called in an
> error-path. Fix this warning by moving the clk_prepare_enable() to its
> own function.
>
> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1425 __s5c73m3_power_off() warn: 'state->clock' from clk_prepare_enable() not released on lines: 1425.
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
To be honest, maybe I should remove the clk_prepare_enable/disable() from the
check_unwind.c. Or at least move them into their own check so that I can
tweak this kind of thing more easily.
regards,
dan carpenter