Re: [PATCH v3] usb: gadget: f_uac1: Change volume name and remove alt names

[Greg Kroah-Hartman]

On Tue, Aug 13, 2024 at 08:56:26AM -0400, Chris Wulff wrote:
> On Tue, Aug 13, 2024 at 4:34 AM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Sat, Aug 03, 2024 at 08:29:13PM -0400, crwulff@xxxxxxxxx wrote:
> > > From: Chris Wulff <crwulff@xxxxxxxxx>
> > >
> > > This changes the UAPI to align with disussion of alt settings work.
> > >
> > > fu_name is renamed to fu_vol_name, and alt settings mode names
> > > are removed for now in favor of future work where they will be
> > > settable in subdirectories for each alt mode.
> > >
> > > discussion thread for api changes for alt mode settings:
> > > https://lore.kernel.org/linux-usb/35be4668-58d3-894a-72cf-de1afaacae45@xxxxxxxxxxx/T/
> >
> > What is now going to break due to this change?  What userspace tools use
> > the old names that need to be changed?
> >
> > Are you _SURE_ that you can rename external files like this and
> > everything will keep on working?
> 
> Nothing is using them, since they were just introduced. I wanted to get
> the API changed before they make it to mainline and somebody starts
> using them.
> 
> You just applied the patch that introduced them into usb-next on 7/31/2024,
> just after v6.11-rc1 so they haven't yet made it to the mainline kernel.
> 
> This is the patch that introduces them:
> 
> https://lore.kernel.org/all/CO1PR17MB541911B0C80D21E4B575E48CE1112@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

Ah, thanks, I totally forgot that.  Remember, I deal with about 1000+
patches a week...

thanks,

greg k-h